Update packages to latest AngleSharp#37
Update packages to latest AngleSharp#37FlorianRappl merged 4 commits intoAngleSharp:masterfrom georgiosd:master
Conversation
| static Object Clr(this JsValue arg) | ||
| { | ||
| return arg.HasValue ? arg.Value.ToObject() : null; | ||
| return arg; |
There was a problem hiding this comment.
Reasons for this? The Clr function converts the JsValue (wrapping a non-JS value) to its original (non-JS) value.
|
Looks good so far. Just some notes:
Regarding 1. you would need to re-PR in any case (I will close it once you re-opened). |
|
Hey @FlorianRappl - the Clr function implementation change was necessary because it's not a nullable type any longer and the code wouldn't compile. Simples :) I'll send you a PR on the devel branch |
|
Well, on the devel branch it seems you are referencing AngleSharp 0.10.0 already which doesn't exist, so I'm not sure if it makes sense to send you a PR there, especially if you're not going to publish a new nuget for the Scripting 0.5.x |
|
We could do a 0.5.1 (and make an exception to use the |
|
@FlorianRappl you're 100% correct - not sure how I missed that. Thanks :) |
|
Looks good - I'll release a v0.5.1 then on NuGet! |
|
Thank you :) |
The tests seem to pass fine