Skip to content

refactor: small structural changes to the library#70

Merged
AngryMaciek merged 8 commits intomasterfrom
refactor
Aug 5, 2023
Merged

refactor: small structural changes to the library#70
AngryMaciek merged 8 commits intomasterfrom
refactor

Conversation

@AngryMaciek
Copy link
Owner

@AngryMaciek AngryMaciek commented Aug 5, 2023

Proposed changes ⤴️

If it fixes a bug or resolves a feature request, please link a corresponding issue:
Fixes #51

Types of changes 🔧

What type of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist ✅

If you're unsure about any of those below, ask explicitly.
This is simply a reminder of what needs to be checked before merging your code.

  • I have read the CONTRIBUTING.
  • I have performed a self-review of my own code.
  • Tests specified with the 'make' framework do not raise any errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e8433b8) 100.00% compared to head (0160e5e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines          893       893           
=========================================
  Hits           893       893           
Files Changed Coverage Δ
hypercomplex/Hypercomplex.hpp 100.00% <100.00%> (ø)
hypercomplex/Hypercomplex_MPFR.hpp 100.00% <100.00%> (ø)
hypercomplex/Polynomial.hpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Dear @AngryMaciek,

It is our utmost pleasure to receive your glorious PR to our humble codebase.
You may kick back & relax for now. Our team will be with you shortly...





Fig 1. Typical GitHub repo: PR assignee & a reviewer arguing over typos.

@AngryMaciek AngryMaciek added the good first issue Good for newcomers label Aug 5, 2023
@AngryMaciek AngryMaciek merged commit 58ff626 into master Aug 5, 2023
@AngryMaciek AngryMaciek deleted the refactor branch August 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers release:patch ci-tag size/XL ci-tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: small code suggestions

1 participant