Skip to content
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2c13efc
First draft of the test case for transform regression fix (5493)
Anirban166 Jul 18, 2024
992608d
Update tests.R
Anirban166 Jul 18, 2024
042e359
Update tests.R
Anirban166 Jul 19, 2024
8bd7e0c
Update tests.R
Anirban166 Jul 19, 2024
30735c3
Update tests.R
Anirban166 Jul 19, 2024
8e79a5d
Update tests.R
Anirban166 Jul 19, 2024
1d99007
Update tests.R
Anirban166 Jul 19, 2024
80362d5
weird results
Anirban166 Jul 19, 2024
4b7cd7a
Update tests.R
Anirban166 Jul 19, 2024
c1b518a
Update tests.R
Anirban166 Jul 19, 2024
1fd4e12
Update tests.R
Anirban166 Jul 19, 2024
62302d2
Update tests.R
Anirban166 Jul 19, 2024
43b731f
Update tests.R
Anirban166 Aug 14, 2024
8d1f6f6
Merge branch 'master' into transform-performance-test
Anirban166 Aug 14, 2024
3c571a8
Update tests.R
Anirban166 Aug 14, 2024
55148c1
More columns/ops
Anirban166 Sep 13, 2024
bea6f4b
Merge branch 'master' into transform-performance-test
Anirban166 Sep 13, 2024
86ea757
Updated SHAs
Anirban166 Sep 13, 2024
5d7c214
Test without the hack
Anirban166 Sep 13, 2024
977c3bd
Adding a conditional op into the mix
Anirban166 Sep 13, 2024
2846467
Test modification addition of columns by reference (in case the commi…
Anirban166 Sep 13, 2024
0e394c8
Testing all the SHAs in master that were referenced in the PR thread.
Anirban166 Sep 13, 2024
31eb765
Update tests.R
Anirban166 Sep 13, 2024
936f26f
Using transform.data.table, simplified test case back to OP's example
Anirban166 Sep 20, 2024
e1e5c4d
Correct SHAs
Anirban166 Sep 20, 2024
0c3ed82
seconds.limit++
Anirban166 Sep 20, 2024
7dcfe84
Test the change in SHA here too, and go with the default spec for sec…
Anirban166 Sep 20, 2024
2436c62
Merge branch 'master' into transform-performance-test
Anirban166 Oct 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .ci/atime/tests.R
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,17 @@ test.list <- atime::atime_test_list(
paste0('useDynLib(', new.Package_))
},

# Fixed in: https://github.com/Rdatatable/data.table/pull/5493 (off-branch)
# Merged to master in: https://github.com/Rdatatable/data.table/commit/2d1a0575f87cc50e90f64825c30d7a6cb6b05dd7
"transform improved in #5493" = atime::atime_test(
N = 10^seq(1, 20),
setup = {
df <- data.frame(x = runif(N))
dt <- as.data.table(df)
},
expr = data.table:::transform.data.table(dt, y = round(x)),
Slow = "0895fa247afcf6b38044bd5f56c0d209691ddb31",
Fast = "2d1a0575f87cc50e90f64825c30d7a6cb6b05dd7"),

tests=extra.test.list)
# nolint end: undesirable_operator_linter.