Skip to content

Testing new commit SHAs to align with code consistency and comment formats #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anirban166 merged 10 commits into from
Oct 3, 2024
Merged

Testing new commit SHAs to align with code consistency and comment formats #18

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
174f05c
Test changes made for consistency first.
Anirban166 Sep 5, 2024
c6f63c0
Update tests.R
Anirban166 Sep 5, 2024
542462e
Update tests.R
Anirban166 Sep 5, 2024
3c94217
Update tests.R
Anirban166 Sep 6, 2024
c2327d2
Update tests.R
Anirban166 Sep 6, 2024
8551f4f
Update tests.R
Anirban166 Sep 10, 2024
904ad93
rm buggy SHA
Anirban166 Sep 10, 2024
3a13c59
Test this with 1.2.1
Anirban166 Sep 10, 2024
aeb9f81
Fixed comments
Anirban166 Sep 10, 2024
b622271
Merge branch 'master' into test-changes
Anirban166 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,5 @@ test.list <- atime::atime_test_list(
paste0('useDynLib(', new.Package_))
},

# Test case created directly using the atime code below (not adapted from any other benchmark), based on the issue/fix PR https://github.com/Rdatatable/data.table/pull/5054#issue-930603663 "melt should be more efficient when there are missing input columns."
"melt improved in #5054" = atime::atime_test(
setup = {
DT <- as.data.table(as.list(1:N))
measure.vars <- lapply(1:N, function(i) {
x = rep(NA, N)
x[i] = i
x
})
},
expr = data.table:::melt(DT, measure.vars = measure.vars),
Slow = "fd24a3105953f7785ea7414678ed8e04524e6955", # Parent of the merge commit (https://github.com/Rdatatable/data.table/commit/ed72e398df76a0fcfd134a4ad92356690e4210ea) of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue
Fast = "ed72e398df76a0fcfd134a4ad92356690e4210ea"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue

tests=extra.test.list)
# nolint end: undesirable_operator_linter.