Conversation
kastrubait
reviewed
Jan 16, 2021
| <mat-form-field> | ||
| <input matInput name="email" ngModel type="email" placeholder="E-Mail" #emailInput="ngModel" required email /> | ||
| <mat-error *ngIf="emailInput.invalid">Please enter a valid email.</mat-error> | ||
| </mat-form-field> |
Collaborator
There was a problem hiding this comment.
This component is very similar with LoginComponent. I think it's worth to think about how to create one common form component
Owner
Author
There was a problem hiding this comment.
I've implemented it that way to have ability to add more properties to SignUp form in future (name, avatar etc...)
| } | ||
| const { email, password } = form.value as AuthData; | ||
| this.authService.createUser(email, password); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think it's better to pass the data as an object User
Collaborator
|
@Anntol |
Owner
Author
|
it is google chrome check for simple passwords |
coriander31415
approved these changes
Jan 17, 2021
Owner
Author
|
Known issues after merge:
|
kastrubait
approved these changes
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.