Skip to content

Set mode#81

Merged
kastrubait merged 7 commits intodevelopfrom
set-mode
Feb 18, 2021
Merged

Set mode#81
kastrubait merged 7 commits intodevelopfrom
set-mode

Conversation

@coriander31415
Copy link
Collaborator

@coriander31415 coriander31415 commented Feb 17, 2021

  • added switch mode toggler to pages (except of 404)
  • fixed white lines on pages
  • get mode through service
  • fix phone background
  • problem: this.pathId is not loaded in ngOninit() on-time (src/app/base/pages/projects-page/projects-page.component.ts)
  • made settings a separate module
  • changed the style of the mode switch
  • fix phone-select: country-code dark-mode

@coriander31415 coriander31415 requested review from Anntol and kastrubait and removed request for kastrubait February 17, 2021 08:10
@coriander31415 coriander31415 linked an issue Feb 17, 2021 that may be closed by this pull request
3 tasks
@kastrubait
Copy link
Collaborator

image

Confused by the size of the switch. Maybe a smaller size will look better? What do you think?

@coriander31415
Copy link
Collaborator Author

Confused by the size of the switch. Maybe a smaller size will look better? What do you think?

@kastrubait
The size is correlated with other icons.
If you wish, you can try other sizes.
But keep in mind animation before and after switch to not destroy it accidetially!

@kastrubait
Copy link
Collaborator

kastrubait commented Feb 18, 2021

problem: this.pathId - solved after splitting into modules and routing settings

  • "save" button need to fix styles

image

@coriander31415
Copy link
Collaborator Author

problem: this.pathId - solved after splitting into modules and routing settings

  • "save" button need to fix styles
  • fixed

image

--

  • sum flex also fixed:
    image

@kastrubait kastrubait merged commit cbe1365 into develop Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings (switch mode)

2 participants