Skip to content

Conversation

@erikgaas
Copy link
Contributor

@erikgaas erikgaas commented Dec 3, 2025

Fixes #757

Line defaults suppressed inheriting of stroke color from parent elements.

@erikgaas erikgaas added the bug Something isn't working label Dec 3, 2025
@gitnotebooks
Copy link

gitnotebooks bot commented Dec 3, 2025

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/804

@erikgaas erikgaas requested a review from jph00 December 3, 2025 00:25
if w: stroke_width=w
return ft_svg('line', x1=x1, y1=y1, x2=x2, y2=y2, stroke=stroke, stroke_width=stroke_width, **kwargs)
if w: stroke_width = w
return ft_hx('line', x1=x1, y1=y1, x2=x2, y2=y2, stroke=stroke, stroke_width=stroke_width, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why switch from ft_svg here?

@jph00
Copy link
Contributor

jph00 commented Dec 7, 2025

Can you check this still seems to work ok?:
https://github.com/AnswerDotAI/fasthtml-example/blob/main/htmx/svgswap.py

And also that the docs render ok?:
https://www.fastht.ml/docs/api/svg.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SVG Line should not have some default parameters

3 participants