Skip to content

[Issue #15] fix trino query execution issues in flink mode #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gengdy1545 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Issue #15] fix trino query execution issues in flink mode #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8875c1
fix: trino query execution issues in flink mode
gengdy1545 Apr 10, 2026
a071db6
fix: guard FreshnessClient calls behind embed mode in PixelsPollingSe…
gengdy1545 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions src/main/java/io/pixelsdb/pixels/sink/freshness/FreshnessClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,12 @@ protected Connection createNewConnection(long queryTimestamp) throws SQLExceptio
properties.setProperty("user", trinoUser);
if (config.isSinkMonitorFreshnessEmbedSnapshot())
{
String catalogName = "pixels";
String sessionPropValue = String.format("%s.query_snapshot_timestamp:%d", catalogName, queryTimestamp);
properties.setProperty("sessionProperties", sessionPropValue);
String catalog = parseCatalogFromUrl(trinoJdbcUrl);
if (catalog != null && catalog.equalsIgnoreCase("pixels"))
{
String sessionPropValue = String.format("%s.query_snapshot_timestamp:%d", catalog, queryTimestamp);
properties.setProperty("sessionProperties", sessionPropValue);
}
}
return DriverManager.getConnection(trinoJdbcUrl, properties);
}
Expand Down Expand Up @@ -410,4 +413,34 @@ private List<String> getStaticList()
{
return config.getSinkMonitorFreshnessEmbedTableList();
}

private String parseCatalogFromUrl(String url)
{
if (url == null || !url.startsWith("jdbc:trino://"))
{
return null;
}
String withoutProtocol = url.substring("jdbc:trino://".length());
int slashIndex = withoutProtocol.indexOf('/');
if (slashIndex == -1)
{
return null;
}
String remaining = withoutProtocol.substring(slashIndex + 1);

int nextSlash = remaining.indexOf('/');
int questionMark = remaining.indexOf('?');

int endIndex = remaining.length();
if (nextSlash != -1)
{
endIndex = nextSlash;
}
if (questionMark != -1 && questionMark < endIndex)
{
endIndex = questionMark;
}

return remaining.substring(0, endIndex);
}
}
9 changes: 4 additions & 5 deletions src/main/java/io/pixelsdb/pixels/sink/writer/flink/PixelsPollingServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ public void pollEvents(SinkProto.PollRequest request, StreamObserver<SinkProto.P
{
SchemaTableName schemaTableName = new SchemaTableName(request.getSchemaName(), request.getTableName());
LOGGER.debug("Received poll request for table '{}'", schemaTableName);
if (freshnessLevel.equals("embed"))
{
FreshnessClient.getInstance().addMonitoredTable(request.getTableName());
}
List<SinkProto.RowRecord> records = new ArrayList<>(pollBatchSize);

try
Expand Down Expand Up @@ -102,11 +106,6 @@ public void pollEvents(SinkProto.PollRequest request, StreamObserver<SinkProto.P
metricsFacade.recordRowEvent(records.size());
metricsFacade.recordTransaction();
this.flushRateLimiter.acquire(records.size());

if (freshnessLevel.equals("embed"))
{
FreshnessClient.getInstance().addMonitoredTable(request.getTableName());
}
}

responseObserver.onNext(responseBuilder.build());
Expand Down