Skip to content

Conversation

@YeetMasterYeet
Copy link

Dear friend, i have added a small contribution to your code where we have 2 motors that can be activated either to lower the water level if it reached a certain level or add water if the water level si too low.

Dear friend, i have added a small contribution to your code where we have 2 motors that can be activated either to lower the water level if it reached a certain level or add water if the water level si too low.
@AnzeKovac
Copy link
Owner

👋
Are you sure this is the only file that needs to be changed ?
Currently i can not test the changes in this PR, since i don't have a dev env.

Also it's all in slovene, is this ok for you ? 😄

I should probably also change some things, since there are hardcoded endpoint in there etc.



}
class Motor{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole section would need some formatting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes my friend i will make the necessary changes in the future days!
Also, i can try and make an english version of the code.

}
class Motor{

motor1(){System.out.println("emtying and filling motors");}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is working correctly in android app ?
Looks like a console application to me.


motor1(){System.out.println("emtying and filling motors");}
Scanner reader = new Scanner(System.in); // Reading from System.in
motor1 b=new motor1();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is motor1 class ?

Copy link
Owner

@AnzeKovac AnzeKovac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide additional feedback, this looks kind of strange

@AnzeKovac
Copy link
Owner

👋
Are you sure this is the only file that needs to be changed ?
Currently i can not test the changes in this PR, since i don't have a dev env.

Also it's all in slovene, is this ok for you ? 😄

I should probably also change some things, since there are hardcoded endpoint in there etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants