-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor cake script #2769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cake script #2769
Conversation
Refactor based on analyser warnings from #2531.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors the Cake build script to address analyzer warnings and minor cleanups.
- Replace unused lambda parameters in Task.Does handlers with discards.
- Switch from RunTarget to awaited RunTargetAsync.
- Add null-forgiving operators when reading JSON config nodes and remove redundant parentheses on object creation.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7123 7123
Branches 1005 1005
=======================================
Hits 6849 6849
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Refactor based on analyser warnings from #2531.