Skip to content

Recursively search all AggregateException InnerExceptions for predicate matches when using HandleInner() #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martincostello merged 2 commits into from
Jan 25, 2021
Merged

Recursively search all AggregateException InnerExceptions for predicate matches when using HandleInner() #824

martincostello merged 2 commits into from
Jan 25, 2021

Conversation

@sideproject
Copy link
Contributor

@sideproject sideproject commented Jan 25, 2021

Recursively search all AggregateException InnerExceptions for predicate matches when using HandleInner()

Related Issue: #818

This is a duplicate of PR #822 to try and fix the CI issue by renaming the source branch.

@martincostello martincostello changed the base branch from master to v722-or-v730 January 25, 2021 16:47
@martincostello martincostello added this to the v7.2.2 milestone Jan 25, 2021
@martincostello martincostello linked an issue Jan 25, 2021 that may be closed by this pull request
When using HandleInner() not all AggregateExceptions are being checked #818
Closed
@martincostello martincostello mentioned this pull request Jan 25, 2021
Closed
@martincostello martincostello merged commit c12997c into App-vNext:v722-or-v730 Jan 25, 2021
@martincostello
Copy link
Member

martincostello commented Jan 25, 2021

Thanks again for your contribution @sideproject! 😃

I'm not sure when the next Polly release will be, I'm still onboarding myself as a maintainer for processes and whatnot, but the fix will be part of the next release (either its v7.2.2 or v7.3.0) when it happens.

@sideproject
Copy link
Contributor Author

sideproject commented Jan 25, 2021

Awesome! It was great to work with you.

@martincostello martincostello mentioned this pull request Apr 11, 2021
Merged
4 tasks
martincostello pushed a commit that referenced this pull request Apr 11, 2021
@sideproject @martincostello
Recursively search all AggregateException InnerExceptions for predica…
3127923 
…te matches when using HandleInner() (#824)

* Recursively search all AggregateException InnerExceptions for predicate matches when using HandleInner() #818

* Add tests for multiple nested aggregate exceptions #818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

v7.2.2

Development

Successfully merging this pull request may close these issues.

When using HandleInner() not all AggregateExceptions are being checked

2 participants

@sideproject @martincostello