Skip to content

Conversation

@304NotModified
Copy link
Contributor

@304NotModified 304NotModified commented Mar 31, 2021

The issue or feature being addressed

Enable deterministic build

Details on the issue fix or feature implementation

Enabled deterministic build. See https://github.com/clairernovotny/DeterministicBuilds

Goals is to have all checks green. Current result:

image

local result:

image

ContinuousIntegrationBuild. These should not be enabled during local dev or the debugger won't be able to find the local source files.

So ContinuousIntegrationBuild is set in the .cake file

Confirm the following

  • I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch -> Yes , v722-or-v730
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch -> Yes , v722-or-v730
  • I have included unit tests for the issue/feature -> not possible
  • I have successfully run a local build -> ran build.ps1

@martincostello martincostello merged commit 0a892d8 into App-vNext:v722-or-v730 Apr 1, 2021
@martincostello
Copy link
Member

Thanks!

@304NotModified 304NotModified deleted the deterministic-build branch April 1, 2021 17:03
@martincostello martincostello added this to the v7.2.2 milestone Apr 11, 2021
@martincostello martincostello mentioned this pull request Apr 11, 2021
4 tasks
martincostello pushed a commit that referenced this pull request Apr 11, 2021
Resolve NuGet Package Explorer warnings.
@304NotModified
Copy link
Contributor Author

FYI, looks great!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants