Restore rotating index for multicolor #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianBinDC
reviewed
May 25, 2020
| XCTAssertEqual(colors.rotate(for: 1), ColorGradient.whiteBlack) | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
💯 on unit tests. That's what was sorely lacking on master. Nice to see folks throwing them in there as they write code, rather than treating them as an afterthought.
Contributor
Author
There was a problem hiding this comment.
Thanks! Working on my TDD skills;) Small functions like that are perfect for it.
AdrianBinDC
reviewed
May 25, 2020
| @@ -0,0 +1,22 @@ | |||
| // | |||
| // File.swift | |||
AdrianBinDC
reviewed
May 25, 2020
| @@ -0,0 +1,45 @@ | |||
| // | |||
| // File.swift | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rotate function to handle multicolor
Motivation and Context
The extension wasn't pushed with the last commit
How Has This Been Tested?
Simulator only
Screenshots (if appropriate):
Types of changes
Checklist: