Skip to content

fix: update badge visibility and daemon restart#135

Merged
CalebisGross merged 2 commits intomainfrom
fix/update-badge-and-restart
Mar 14, 2026
Merged

fix: update badge visibility and daemon restart#135
CalebisGross merged 2 commits intomainfrom
fix/update-badge-and-restart

Conversation

@CalebisGross
Copy link
Copy Markdown
Collaborator

Summary

Follow-up fixes for the self-update feature (#132):

  • Fix badge text invisible across all themes — .nav-brand uses -webkit-text-fill-color: transparent for its gradient effect, which cascaded to the badge. Reset text-fill-color and background-clip on the badge.
  • Fix badge font too large — .nav-brand span forced 1.3rem on all child spans. Add specific .update-badge override.
  • Fix daemon restart killing itself — Stop() + Start() sent SIGTERM to the running process, so Start() never executed. Added Restart() to ServiceManager interface using non-blocking exec.Command.Start() (systemctl --user restart / launchctl stop+start / net stop+start) so the command outlives the dying process.

Test plan

  • Badge text visible on all themes (Midnight, Ember, Nord, Slate, Parchment)
  • Badge properly sized (0.7rem, not inheriting 1.3rem from nav-brand)
  • make build && make check pass
  • golangci-lint run clean on all changed packages
  • Dashboard update button triggers restart and daemon comes back up

🤖 Generated with Claude Code

CalebisGross and others added 2 commits March 14, 2026 19:28
White text on green background instead of --bg-primary (near-black),
slightly larger font and padding, nowrap to prevent text wrapping.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix badge text invisible due to nav-brand's -webkit-text-fill-color:
  transparent cascading to children. Reset text-fill-color and
  background-clip on the badge element.
- Fix badge font-size overridden by .nav-brand span rule (1.3rem).
  Add specific .nav-brand .update-badge override.
- Fix daemon self-restart: Stop()+Start() killed the process before
  Start() could run. Add Restart() to ServiceManager interface that
  uses non-blocking exec (systemctl restart / launchctl stop+start /
  net stop+start) so the command outlives the dying process.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@CalebisGross CalebisGross merged commit e8fe843 into main Mar 14, 2026
7 checks passed
@CalebisGross CalebisGross deleted the fix/update-badge-and-restart branch March 14, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant