fix: filter binary asset paths and numeric segments from concept extraction#310
Merged
CalebisGross merged 1 commit intomainfrom Mar 21, 2026
Merged
fix: filter binary asset paths and numeric segments from concept extraction#310CalebisGross merged 1 commit intomainfrom
CalebisGross merged 1 commit intomainfrom
Conversation
…action Expand the skip list in FromPath to filter out asset directories (images, icons, fonts, docs), generic noise segments (bytes, data, cache), and documentation directories. Add isNumeric filter to drop dimension-like segments (96x96, 512x512) from themes. Fixes #305 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Not a bug — the watcher works correctly. Investigation revealed:
Verified The initial test used only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FromPathto filter asset directories (images,icons,fonts,docs), generic noise (bytes,data,cache), and documentation directoriesisNumericfilter to drop dimension-like segments (96x96,512x512)FromEventTypeusingstrings.CutPrefix(lint fix)Before: themes included
docs/images/mnemonic.png,bytes,96x96After: themes include only
mnemonic,favicon, etc.Test plan
make build && make checkcleanFixes #305
🤖 Generated with Claude Code