fix: encoding faithfulness, amend raw_id, dashboard timeline#385
Merged
CalebisGross merged 1 commit intofeat/exp25-faithfulness-probefrom Apr 9, 2026
Merged
Conversation
- Remove getRelatedContext() from encoding pipeline — FTS5 keyword matching injected unrelated memory summaries into the LLM prompt, causing cross-contamination (#383). Also removes extractKeywords and joinConcepts (dead code after removal). - amend tool now accepts raw_id in addition to memory_id, resolving via GetMemoryByRawID when memory_id lookup fails (#382). Mirrors the check_memory pattern. - Dashboard: fix sticky "Today" header overlapping first timeline entry (top: 30px → 0, solid background). Fix time formatting producing single-digit minutes (manual zero-padding replaces locale-dependent toLocaleString). - Sync Python training_constants.py with Go buildCompressionPrompt (remove related_ctx parameter). Remove RELATED_MEMORY_STUB from prepare_faithfulness_data.py. Closes #382, closes #383 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amendtool now acceptsraw_id(fromremember) in addition tomemory_id, mirroringcheck_memory's resolution patterngetRelatedContext()from the encoding pipeline — FTS5 keyword matching was injecting unrelated memory summaries into the LLM compression prompt, causing cross-contamination (e.g., a "V7 dataset pipeline" memory got encoded as "Major architecture pivot"). Also removed dead helper functions (extractKeywords,joinConcepts) and their testsbuild_production_prompt()with GobuildCompressionPrompt()(removedrelated_ctxparameter andRELATED_MEMORY_STUB)Test plan
make checkpasses (go fmt + go vet)go test ./internal/agent/encoding/... ./internal/mcp/...— all passmake test— only pre-existingTestFormatPromptfailure (ChatML format mismatch, unrelated)ROCM=1 make build-embeddedsucceedsCloses #382, closes #383
🤖 Generated with Claude Code