Skip to content

Conversation

@Araxeus
Copy link
Owner

@Araxeus Araxeus commented Dec 11, 2025

No description provided.

@snyk-io
Copy link

snyk-io bot commented Dec 11, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a JSON Schema file for vendorfiles configuration, providing validation and autocompletion support in modern editors. The changes also include cleanup of deprecated name fields from example files and updated documentation explaining how to use the schema.

  • Adds comprehensive JSON Schema definition with validation rules, examples, and documentation
  • Removes obsolete name field from example configuration files
  • Reorganizes Quick Start section in README for better clarity
  • Adds new JSON Schema section in documentation with usage examples

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vendorfiles.schema.json New comprehensive JSON Schema defining the structure, validation rules, and documentation for vendorfiles configuration files
examples/vendor.yml Removed deprecated name field and normalized quote style
examples/vendor.toml Removed deprecated name field
examples/vendor.json Removed deprecated name field and fixed trailing whitespace
README.md Reorganized Quick Start section, removed Installation heading, and added new JSON Schema documentation section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"additionalProperties": false
},
"defaultOptions": {
"type": "object",
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaultOptions definition uses both type: object and $ref at the same level, which is redundant. In JSON Schema, when you use $ref, other keywords at the same level are typically ignored (though this behavior changed in later drafts). Since vendorDependency is already defined as type object, you should remove the redundant type: object line here.

Suggested change
"type": "object",

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeeeeeeeeeeeeeeeeeh nit

…t required fields

Refactor schema to use vendorDependencyBase for shared properties, allowing defaultOptions to have all properties optional while vendorDependency requires repository and files. Also allow files to be a single string.
@Araxeus Araxeus merged commit c843c67 into main Jan 3, 2026
11 checks passed
@Araxeus Araxeus deleted the create-vendorfiles.schema.json branch January 3, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants