Skip to content

Conversation

@robfrank
Copy link
Collaborator

@robfrank robfrank commented Jan 14, 2025

What does this PR do?

REwork of #1911

Motivation

Some tests are failing after merge of PR #1911

Related issues

issues: #1763

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank force-pushed the fix/1763-fix-failing-tests branch from d614ccc to 86bc7a3 Compare January 14, 2025 19:45
@codacy-production
Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.46% 59.38%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (971b6a8) 68176 43654 64.03%
Head commit (df37359) 68195 (+19) 43977 (+323) 64.49% (+0.46%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1914) 32 19 59.38%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@robfrank robfrank marked this pull request as ready for review January 15, 2025 08:10
@robfrank robfrank merged commit f086acb into main Jan 15, 2025
9 of 12 checks passed
@robfrank robfrank changed the title Rework on create edge is not exists #1763 add logic to retrieve existing edge to CreateEdgesStep Jan 15, 2025
@robfrank robfrank deleted the fix/1763-fix-failing-tests branch June 20, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants