PIDReview: add embedded documentation tooltips #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@IamPete1 I've added embedded tooltips to the PID Review tool using the same approach as Filter Review. Please let me know if you'd like wording or placement adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds embedded documentation tooltips to the PID Review tool, following the same pattern used in the Filter Review tool.
The tooltips provide descriptive explanations of each plot and section (Flight Data, Time Domain, Frequency Domain, Step Response, and PID Spectrogram) without offering tuning guidance.
The wording is intentionally conservative and based on the existing PID Review description and displayed data.
Happy to refine text or placement based on maintainer feedback.
Closes #247