Textblobfix#12
Merged
Merged
Conversation
DrLynch
approved these changes
Apr 25, 2025
bradley-erickson
left a comment
bradley-erickson
left a comment
There was a problem hiding this comment.
Looks good, but see my comment on the other PR about making sure you have the upstream changes (~10 commits from ETS side of things). This will make sure there aren't merge conflicts when you merge and subsequently when I merge these changes into ETS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with newer versions of spacy, spacytextblob no longer references document/token features the same way; namely, the new convention is X..blob.Y instead of X..Y.
These fixes should bring spacytextblob usage up to current. However, there is a little "hack" fix for utility functions, which assumes that the former nomenclature for referencing spacytextblob still remains the same. I added some conditionals/replacements to checking indicators so that referencing "blob" is included and valid.