Import clean#13
Conversation
DrLynch
left a comment
DrLynch
left a comment
There was a problem hiding this comment.
On the whole this looks good. I approve the changes but I leave it to Brad to verify it won't cause any issues on his end.
| awe_lexica @ git+https://github.com/ArgLab/AWE_Lexica.git | ||
| spacy | ||
| coreferee | ||
| coreferee @ git+https://github.com/Arglab/coreferee.git@latest_spacy |
There was a problem hiding this comment.
Is this pointing to the appropriate place? Should it be the main branch instead?
What is different about the Arglab coreferee compared to the original corefereee?
| @@ -0,0 +1,61 @@ | |||
| AWE_Info | |||
There was a problem hiding this comment.
What is this file for? We should at least include a comment as to why it exists or note its purpose in the documentation.
|
General comment: Has the Arglab version of this been synced with the ETS version? |
3 participants
Added cleanups to imports in major components to AWE_Components; this should make install/run a little more lightweight. Also removed unnecessary imports, and removed outdated imports for the current version of spacy (3.8).