Skip to content

Making fixes across the system to switch camel to underscore case.#28

Merged
bradley-erickson merged 8 commits into
masterfrom
underscorefix
Jan 26, 2023
Merged

Making fixes across the system to switch camel to underscore case.#28
bradley-erickson merged 8 commits into
masterfrom
underscorefix

Conversation

@DrLynch
Copy link
Copy Markdown
Collaborator

@DrLynch DrLynch commented Dec 25, 2022

This isolates the camel case to undescore fix in the rosters and downstream changes as well as the addition of the prototype dashboard to the display for testing.

…. We had broken the connection between doc and student with the reorder and were pulling in errors from inactive students. This presents a fix for both things.
…t we had. We had broken the connection between doc and student with the reorder and were pulling in errors from inactive students. This presents a fix for both things."

This reverts commit 8be593d.
Comment thread learning_observer/learning_observer/rosters.py Outdated
Comment thread learning_observer/learning_observer/rosters.py Outdated
Comment thread learning_observer/learning_observer/rosters.py Outdated
Comment thread learning_observer/learning_observer/dashboard.py Outdated
Comment thread learning_observer/learning_observer/dashboard.py Outdated
Comment thread learning_observer/learning_observer/dashboard.py Outdated
Comment thread learning_observer/learning_observer/dashboard.py Outdated
Comment thread learning_observer/learning_observer/dashboard.py Outdated
Comment thread learning_observer/learning_observer/rosters.py Outdated
- Fixed some bugs where items weren't present when google data didn't exist (adding defaults)
- this also removes the comment below it (changes addressed this comment)
@bradley-erickson bradley-erickson merged commit 3ae1c89 into master Jan 26, 2023
@bradley-erickson bradley-erickson deleted the underscorefix branch September 11, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants