Conversation
Member
Author
|
It occurred to me that a lot of calls of getCursor were added, and this method recompute the position every time it's called, from scratch. An alternative will have to be created, so that we can dynamically compute the line and column number when calling next/backtrack, without requiring to recompute from scratch said cursor. Edit: this has been fixed, see BaseParser and the usage of m_it_to_row. |
2e33e10 to
ed5db0f
Compare
…alysis tools to run on PRs
…tering the interface
…s go together in blocks
ed5db0f to
59ccf88
Compare
ee2784e to
e2198ea
Compare
c9d2a01 to
a0ff755
Compare
Static analysis reportLizard reportListing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 10.
CppCheck report |
a0ff755 to
0ac0153
Compare
3d8bafa to
2337008
Compare
2337008 to
80ca896
Compare
2f188a7 to
5907063
Compare
…comments after nodes too
5907063 to
6e81769
Compare
6e81769 to
a773898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a very simple and non-configurable ArkScript code formatter to the CLI.
It seems that with the parser modifications this PR required, the parsing times went up by a lot. I'll need to confirm and check why.
Closes #421
Checklist