Fixed bottom face of the cube#95
Merged
ElhamAryanpur merged 2 commits intoAryanpurTech:masterfrom Mar 21, 2025
Merged
Conversation
Contributor
Author
|
Edit: also fixed uv of the top face. Before: After: |
Contributor
|
Sorry, this issue is entirely my fault when going from |
Contributor
Author
|
No need to sorry, its fine. I just propose fixes for bugs I find, as I am trying to use this engine. |
USSURATONCACHI
temporarily deployed
to
production
GitHub Actions
Inactive
USSURATONCACHI
temporarily deployed
to
production
GitHub Actions
Inactive
USSURATONCACHI
temporarily deployed
to
production
GitHub Actions
Inactive
Collaborator
|
These are absolutely awesome, I was planning on reviewing what broke them but you fixed them. I think a review of the Vector type is needed to ensure this fix is propagated along all examples and older code as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
