Skip to content

v0.6.12#87

Merged
rebelinux merged 3 commits intoAsBuiltReport:devfrom
rebelinux:dev
Mar 16, 2026
Merged

v0.6.12#87
rebelinux merged 3 commits intoAsBuiltReport:devfrom
rebelinux:dev

Conversation

@rebelinux
Copy link
Copy Markdown
Collaborator

[0.6.12] - Unreleased

Added

  • Add Vserver resources diagram showing SVM information, allocated aggregates, and network interfaces (LIFs)
  • Add Network ports diagram showing all network ports and their associated LIFs
  • Add Volume resources usage to the vserver diagram
  • Add node owner (Home Node) to network interface tables (Vserver, Cluster, Management, Intercluster, and Data network interfaces)
  • Add Health Check best practices for Network Broadcast Domains
  • Add Health Check best practices for NTP configuration
    • Recommend multiple NTP servers for redundancy
  • Add Per Volume export policy information
  • Add Node Name to FCP Interfaces section in FCP Vserver configuration
  • Apply powershell best practices
  • Add ConvertTo-HashToYN function
  • Add EMS configuration setting health check
  • Add support for charts
    • Aggragate Usage
    • Per Node Disk Assignment

Changed

  • Migrate from Diagrammer.Core to AsBuiltReport.Diagram for diagram generation
  • Bump AsBuiltReport.Chart module requirement to v0.3.0
  • Bump AsBuiltReport.Core module requirement to v1.6.2
  • Bump NetApp.ONTAP module requirement to v9.18.1.2601
  • Bump module version to v0.6.12
  • Update github actions to use latest version
  • Export diagrams by default
  • Improved Cluster diagram to show Broadcast Domains and network ports per node

Fixed

  • Fix snapshot reserve space health check to use correct calculation method
  • Enhance Get-AbrOntapNodesSP function with detailed service-processor information
  • Fix model property assignment in Get-AbrOntapStorageAggrDiagram function
  • Fix Volume SnapShot Configuration section showing healthcheck for non violated item
  • Fix CodeQL analysis issues 27
  • Fix diagram size not respecting document border size
  • Fix HealthCheck - Volume without deduplication section displaying incorrect values
  • Fix type conversion for volume usage percentage checks in Get-AbrOntapVserverVolume function
  • Fix: Join management addresses into a comma-separated string in cluster and node diagrams

Removed

  • Removed Pwsh v5.1 support

- Updated function calls from `Add-Dia*` to `Add-*` for consistency across diagram generation scripts.
- Changed `Remove-SpecialChar` to `Remove-SpecialCharacter` for improved clarity in `Get-AbrOntapClusterDiagram.ps1`.
- Adjusted edge and node creation methods in `Get-AbrOntapClusterReplicationDiagram.ps1`, `Get-AbrOntapNodeAggrDiagram.ps1`, and `Get-AbrOntapNodeNetworkDiagram.ps1` to reflect new naming.
- Enhanced readability and maintainability of the code by standardizing function names and parameters.
Copilot AI review requested due to automatic review settings March 16, 2026 17:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NetApp ONTAP report’s diagram generation to align with the AsBuiltReport.Diagram module APIs and naming, as part of the v0.6.12 diagramming migration.

Changes:

  • Replaced legacy Add-Dia* diagram helper calls with Add-* equivalents across multiple diagram builders.
  • Updated diagram export pipeline to use New-AbrDiagram and Get-BestImageAspectRatio.
  • Standardized some node-name sanitization calls to Remove-SpecialCharacter in cluster-related diagrams.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Src/Private/Get-AbrOntapVserverDiagram.ps1 Migrates Vserver diagram node/subgraph/edge helpers to new diagram module function names.
Src/Private/Get-AbrOntapNodeNetworkDiagram.ps1 Migrates node network diagram primitives (images, icons, subgraphs, edges) to new helper functions.
Src/Private/Get-AbrOntapNodeAggrDiagram.ps1 Updates aggregate diagram node table/subgraph generation to new helpers.
Src/Private/Get-AbrOntapClusterReplicationDiagram.ps1 Updates replication diagram helpers and node-name sanitization function naming.
Src/Private/Get-AbrOntapClusterDiagram.ps1 Updates cluster diagram helpers and switches sanitization calls to Remove-SpecialCharacter.
Src/Private/Export-AbrOntapDiagram.ps1 Switches export creation and aspect-ratio helper to AsBuiltReport.Diagram-aligned functions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@rebelinux rebelinux merged commit 9275b3e into AsBuiltReport:dev Mar 16, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants