Merged
Conversation
- Updated function calls from `Add-Dia*` to `Add-*` for consistency across diagram generation scripts. - Changed `Remove-SpecialChar` to `Remove-SpecialCharacter` for improved clarity in `Get-AbrOntapClusterDiagram.ps1`. - Adjusted edge and node creation methods in `Get-AbrOntapClusterReplicationDiagram.ps1`, `Get-AbrOntapNodeAggrDiagram.ps1`, and `Get-AbrOntapNodeNetworkDiagram.ps1` to reflect new naming. - Enhanced readability and maintainability of the code by standardizing function names and parameters.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NetApp ONTAP report’s diagram generation to align with the AsBuiltReport.Diagram module APIs and naming, as part of the v0.6.12 diagramming migration.
Changes:
- Replaced legacy
Add-Dia*diagram helper calls withAdd-*equivalents across multiple diagram builders. - Updated diagram export pipeline to use
New-AbrDiagramandGet-BestImageAspectRatio. - Standardized some node-name sanitization calls to
Remove-SpecialCharacterin cluster-related diagrams.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Src/Private/Get-AbrOntapVserverDiagram.ps1 | Migrates Vserver diagram node/subgraph/edge helpers to new diagram module function names. |
| Src/Private/Get-AbrOntapNodeNetworkDiagram.ps1 | Migrates node network diagram primitives (images, icons, subgraphs, edges) to new helper functions. |
| Src/Private/Get-AbrOntapNodeAggrDiagram.ps1 | Updates aggregate diagram node table/subgraph generation to new helpers. |
| Src/Private/Get-AbrOntapClusterReplicationDiagram.ps1 | Updates replication diagram helpers and node-name sanitization function naming. |
| Src/Private/Get-AbrOntapClusterDiagram.ps1 | Updates cluster diagram helpers and switches sanitization calls to Remove-SpecialCharacter. |
| Src/Private/Export-AbrOntapDiagram.ps1 | Switches export creation and aspect-ratio helper to AsBuiltReport.Diagram-aligned functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.6.12] - Unreleased
Added
Node Nameto FCP Interfaces section in FCP Vserver configurationChanged
Fixed
Removed