Add CLI flag --gpu=drm|venus|software to support various GPU virtualization modes#195
Conversation
valpackett
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
crates/muvm/src/bin/muvm.rs
Outdated
|
|
||
| let virgl_flags = VIRGLRENDERER_USE_EGL | ||
| | VIRGLRENDERER_DRM | ||
| | VIRGLRENDERER_NO_VIRGL |
There was a problem hiding this comment.
Is this flag supposed to be set unconditionally?
There was a problem hiding this comment.
Yeah, after submitting I realized I should've added a comment there – it's seems to only be strictly necessary when not having any dri nodes present (software-only with no GPU devices present, without this flag → guest hang)..
However, legacy virGL is not very desirable (especially in terms of security) and doesn't actually work anyway. So I think it's better to hard-disable it unconditionally.
Yes, please export that variable when Venus is selected. |
valpackett
force-pushed
the
val/myousnxpksmm
branch
from
2bfe82d to
f5a3df8
Compare
|
@valpackett there's just a minor clippy issue remaining. Once fixed I think we can merge it and cut a new release. |
…zation modes vDRM is great, but not supported everywhere yet, so on some machines the only way to get GPU acceleration is via Venus. Also, make it possible to use software rendering only while still having working cross-domain Wayland. Signed-off-by: Val Packett <val@invisiblethingslab.com>
valpackett
force-pushed
the
val/myousnxpksmm
branch
from
f5a3df8 to
59cfdf9
Compare
|
Fixed \o/ |
3 participants
vDRM is great, but not supported everywhere yet, so on some machines the only way to get GPU acceleration is via Venus. Also, make it possible to use software rendering only while still having working cross-domain Wayland.
Should we also automatically set
MESA_LOADER_DRIVER_OVERRIDE=zinkwhen Venus is selected?