guest/server: pass exit code back to pid1#201
Merged
slp merged 1 commit intoAsahiLinux:mainfrom Oct 31, 2025
Merged
Conversation
valpackett
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
teohhanhui
requested changes
Oct 24, 2025
valpackett
force-pushed
the
val/mzxsrxpqwvmz
branch
from
bd0e776 to
d9265da
Compare
Contributor
Author
|
Bubbled up the whole |
teohhanhui
reviewed
Oct 25, 2025
crates/muvm/src/guest/server.rs
Outdated
|
|
||
| let mut server_died = false; | ||
| let mut command_exited = false; | ||
| let mut command_exited_code = None; |
Collaborator
There was a problem hiding this comment.
Suggested change
| let mut command_exited_code = None; | |
| let mut command_exit_code = None; |
nit
Contributor
Author
There was a problem hiding this comment.
Suure. I tried to make it clearer that "it definitely had exited if this is Some" with the name, but evidently that was too awkward and unnecessary :)
teohhanhui
approved these changes
Oct 25, 2025
libkrun's built-in init supports reporting the exit code back to the host from the program it launches. Let's not break the chain here! Signed-off-by: Val Packett <val@invisiblethingslab.com>
valpackett
force-pushed
the
val/mzxsrxpqwvmz
branch
from
d9265da to
e6c8e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libkrun's built-in init supports reporting the exit code back to the host from the program it launches. Let's not break the chain here!