Merged
Conversation
Collaborator
|
@WhatAmISupposedToPutHere Judging from the commit history, does this PR depend on #47? That's still in draft status anyway. |
Collaborator
Author
|
Technically yes, but i am not super sure why that one is marked as draft. |
alyssarosenzweig
force-pushed
the
interactive
branch
from
b84e835 to
f7717a5
Compare
alyssarosenzweig
requested review from
alyssarosenzweig and
hoshinolina
as code owners
alyssarosenzweig
force-pushed
the
interactive
branch
from
f7717a5 to
e1feb6b
Compare
WhatAmISupposedToPutHere
force-pushed
the
interactive
branch
from
e1feb6b to
98f542b
Compare
Collaborator
|
I think we should get this one merged for the next release. Can you please rebase it? |
Unconditionally forward a range of ports to sockets named `$XDG_RUNTIME_DIR/krun/socket/port-$PORT`. This allows applications to dynamically bind to sockets at those paths and have them forwarded to the guest as vsock ports, after the krun VM is already running. The port range is currently hardcoded as 50000..50200. Signed-off-by: Asahi Lina <lina@asahilina.net> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
interactive
branch
from
98f542b to
14739bb
Compare
After launching a process via the server, krun immediately closes and the
launched process' std{in,out,err} go nowhere. Add a --interactive flag that
allocates a pseudo-terminal, routes it to the host and connects to it.
Somewhat like '-it' in docker/podman exec.
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
interactive
branch
from
14739bb to
203f1c6
Compare
slp
approved these changes
Dec 2, 2024
Collaborator
slp
left a comment
slp
left a comment
There was a problem hiding this comment.
Reviewed and tested, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After launching a process via the server, krun immediately closes and the
launched process' std{in,out,err} go nowhere. Add a --interactive flag that
allocates a pseudo-terminal, routes it to the host and connects to it.
Somewhat like '-it' in docker/podman exec.