[chore] Optimize pyproject and CI script#13
Conversation
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
There was a problem hiding this comment.
Pull request overview
This PR optimizes the project configuration and CI workflows by consolidating dependency management and streamlining build processes.
Changes:
- Enables mypy type checking globally by setting
ignore_errors = falseand removes module-specific overrides - Reorganizes optional dependencies in pyproject.toml into separate groups (build, test, yuanrong)
- Refactors CI workflows to use pip editable installs with optional dependencies instead of explicit package lists
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyproject.toml | Enables strict mypy type checking globally, adds structured optional dependencies for build/test/yuanrong, and removes outdated module overrides |
| .github/workflows/sanity.yml | Removes unnecessary dependency installation steps since sanity checks only use standard library |
| .github/workflows/python-package.yml | Switches from wheel build + install to editable install with optional dependencies, adds separate test build step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
d457687 to
61aadaf
Compare
Signed-off-by: tianyi-ge <tianyig@outlook.com>
1. set -> list 2. controller info is required Signed-off-by: tianyi-ge <tianyig@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
transfer_queue/storage/clients/yuanrong_client.py:119
- This class does not call TransferQueueStorageKVClient.init during initialization. (YuanrongStorageClient.init may be missing a call to a base class init)
class YuanrongStorageClient(TransferQueueStorageKVClient):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
transfer_queue/storage/clients/yuanrong_client.py:119
- This class does not call TransferQueueStorageKVClient.init during initialization. (YuanrongStorageClient.init may be missing a call to a base class init)
class YuanrongStorageClient(TransferQueueStorageKVClient):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
pyproject.toml, addbuild,test,yuanrongas optional dependencies.