Correct scale for Amount_of_charged_energy#2
Open
pseudex wants to merge 1 commit into
Open
Conversation
Amount_of_charged_energy was scaled with 100. Since Amount_of_discharged_energy is also kWh and scale is 0.01 the same should apply here. Here the values from a SmartShunt 500 with the correction Amount_of_charged_energy 0.33 kWh 2024-10-29 18:27:20 Amount_of_discharged_energy 0.39 kWh 2024-10-29 18:20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amount_of_charged_energy was scaled with 100. Since Amount_of_discharged_energy is also kWh and scale is 0.01 the same should apply here.
Here the values from a SmartShunt 500 with the correction
Amount_of_charged_energy
0.33 kWh
2024-10-29 18:27:20
Amount_of_discharged_energy
0.39 kWh
2024-10-29 18:20:08