Skip to content

Fixed compiler constant hint in typescript typedefs #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcodeIO merged 3 commits into from
Jun 9, 2020
Merged

Fixed compiler constant hint in typescript typedefs #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea5ed6
Add name to NOTICE, also update assembly/index.d.ts
gzuidhof Jun 8, 2020
2ed3972
Update portable typedef
gzuidhof Jun 8, 2020
5707765
Add explicit values to target enum
gzuidhof Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ under the licensing terms detailed in LICENSE:
* Duncan Uszkay <duncan.uszkay@shopify.com>
* Surma <surma@surma.dev>
* Julien Letellier <letellier.julien@gmail.com>
* Guido Zuidhof <me@guido.io>

Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
2 changes: 1 addition & 1 deletion std/assembly/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ declare type anyref = object;

// Compiler hints

/** Compiler target. 0 = JS, 1 = WASM32, 2 = WASM64. */
/** Compiler target. 0 = WASM32, 1 = WASM64, 2 = JS. */
declare const ASC_TARGET: i32;
/** Provided noAssert option. */
declare const ASC_NO_ASSERT: bool;
Expand Down
6 changes: 3 additions & 3 deletions std/assembly/shared/target.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
/** Compilation target. */
export enum Target {
/** WebAssembly with 32-bit pointers. */
WASM32,
WASM32 = 0,
/** WebAssembly with 64-bit pointers. Experimental and not supported by any runtime yet. */
WASM64,
WASM64 = 1,
/** Portable. */
JS
JS = 2
}
2 changes: 1 addition & 1 deletion std/portable/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ declare type valueof<T extends unknown[]> = T[0];

// Compiler hints

/** Compiler target. 0 = JS, 1 = WASM32, 2 = WASM64. */
/** Compiler target. 0 = WASM32, 1 = WASM64, 2 = JS. */
declare const ASC_TARGET: i32;
/** Provided noAssert option. */
declare const ASC_NO_ASSERT: bool;
Expand Down