Skip to content

Conversation

@ncave
Copy link
Contributor

@ncave ncave commented Jun 10, 2020

  • Fixed default package template's exports.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 11, 2020

Oh, right, the loader's instantiate result changed lately and this hasn't been updated. LGTM in general, but a simpler fix with less changes might be simply

"module.exports = loader.instantiateSync(fs.readFileSync(__dirname + \"/build/optimized.wasm\"), { /* imports */ }).exports"

unless you think that it adds clarity as proposed here?

@ncave
Copy link
Contributor Author

ncave commented Jun 11, 2020

@dcodeIO Yes, the separate line is just for clarity.

@dcodeIO dcodeIO merged commit 4808e4d into AssemblyScript:master Jun 11, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Jun 11, 2020

Alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants