refactor: sinh overflows in non-nearest rounding

[MaxGraey]

sync with musl's commit

The final rounding operation should be done with the correct sign
otherwise huge results may incorrectly get rounded to or away from
infinity in upward or downward rounding modes.

This affected sinh and sinhf which set the sign on the result after
a potentially overflowing mul. There may be other non-nearest rounding
issues, but this was a known long standing issue with large ulp error
(depending on how ulp is defined near infinity).

The fix should have no effect on sinh and sinhf performance but may
have a tiny effect on cosh and coshf.

In theory it shouldn't affect to us due to Wasm guarantee always have round-to-nearest mode. But It's cost nothing in term of performance and sync with musl's implementation at the same time so I guess it worth implement on our side as well.

• I've read the contributing guidelines

[dcodeIO]

In theory it shouldn't affect to us due to Wasm guarantee always have round-to-nearest mode.

So, is it safe to omit the fix: label here?

[MaxGraey]

So, is it safe to omit the fix: label here?

yes. Removed it

[dcodeIO]

Thanks for looking into these upstream musl changes! :)

[github-actions]

🎉 This PR is included in version 0.14.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀