Update Binaryen to latest / allowInliningFunctionsWithLoops bindings

[dcodeIO]

Also adds bindings for BinaryenGetAllowInliningFunctionsWithLoops and BinaryenSetAllowInliningFunctionsWithLoops.

• I've read the contributing guidelines

[dcodeIO]

Tests are failing due to the new APIs not being exported yet.

[dcodeIO]

Interesting, setting allowHeavyweight to true doesn't change any fixtures. Is this expected?

[MaxGraey]

Interesting, setting allowHeavyweight to true doesn't change any fixtures. Is this expected?

Yes. It's only affected to exported function which relatively small but contain for example loops. See this test

[dcodeIO]

Can you add a test for this in a follow-up PR?

[dcodeIO]

Also, I don't see how this now affects optimize levels, for instance whether it can theoretically yield larger modules on high shrink levels, and I'd appreciate if you could explain :)

[MaxGraey]

Also, I don't see how this now affects optimize levels, for instance whether it can theoretically yield larger modules on high shrink levels, and I'd appreciate if you could explain :)

No It's affect only to -O3 on binaryen side. It's hardcoded as:

return options.optimizeLevel >= 3 && options.shrinkLevel == 0 &&
           (lightweight || options.inlining.allowHeavyweight);

[dcodeIO]

What do you think of setting this option to true only if optimizeLevel > 2 on our end then, just to be sure? Would be clearer to me.

[MaxGraey]

What do you think of setting this option to true only if optimizeLevel > 2 on our end then, just to be sure? Would be clearer to me.

ok

[dcodeIO]

Let me know if this does what you want now :)

[MaxGraey]

LGTM. Thanks!

[dcodeIO]

Interesting, hitting an assertion now indicating that somewhere somehow an expression is null.

[MaxGraey]

Interesting, hitting an assertion now indicating that somewhere somehow an expression is null.

Yes, and it's happening in wasm-traversal.h in this line. Could you check previous version of binaryen which contain this PR?

[dcodeIO]

Full error isn't super useful unfortunately

Assertion failed: *task.currp, at: /home/runner/work/binaryen.js/binaryen.js/binaryen/src/wasm-traversal.h,702,walk
Error: abort(Assertion failed: *task.currp, at: /home/runner/work/binaryen.js/binaryen.js/binaryen/src/wasm-traversal.h,702,walk). Build with -s ASSERTIONS=1 for more info.
    at q (\path\to\assemblyscript\node_modules\binaryen\index.js:55:227)
    at i (\path\to\assemblyscript\node_modules\binaryen\index.js:104:50)
    at ACb (\path\to\assemblyscript\node_modules\binaryen\index.js:17:573541)
    at Pc (\path\to\assemblyscript\node_modules\binaryen\index.js:177:266)
    at w8 (\path\to\assemblyscript\node_modules\binaryen\index.js:17:686915)
    at CCb (\path\to\assemblyscript\node_modules\binaryen\index.js:13:2243554)
    at maa (\path\to\assemblyscript\node_modules\binaryen\index.js:13:1201277)
    at rJb (\path\to\assemblyscript\node_modules\binaryen\index.js:25:188687)
    at CJb (\path\to\assemblyscript\node_modules\binaryen\index.js:25:361239)
    at Oc (\path\to\assemblyscript\node_modules\binaryen\index.js:177:367)
    at EJb (\path\to\assemblyscript\node_modules\binaryen\index.js:13:1593565)
    at pLb (\path\to\assemblyscript\node_modules\binaryen\index.js:25:783)
    at GLb (\path\to\assemblyscript\node_modules\binaryen\index.js:25:2271)
    at jfb (\path\to\assemblyscript\node_modules\binaryen\index.js:17:392657)
    at Oc (\path\to\assemblyscript\node_modules\binaryen\index.js:177:367)
    at Object.pgb [as _BinaryenModuleAllocateAndWrite] (\path\to\assemblyscript\node_modules\binaryen\index.js:13:2136119)
    at Module.toBinary (\path\to\assemblyscript\src\module.ts:1695:14)
    at \path\to\assemblyscript\cli\asc.js:830:23
    at measure (\path\to\assemblyscript\cli\asc.js:1103:3)
    at Object.main (\path\to\assemblyscript\cli\asc.js:829:25)
    at \path\to\assemblyscript\bin\asc:21:47

[MaxGraey]

also could you disable setAllowInliningFunctionsWithLoops(false) for exclude issue with inlining?

[dcodeIO]

Error also happens if I comment out the setAllowInliningFunctionsWithLoops lines. Going to look for the last working nightly.

[dcodeIO]

Last working is 96.0.0-nightly.20200903.

[dcodeIO]

PRs in between last working and first failing: WebAssembly/binaryen#3098 WebAssembly/binaryen#3101 WebAssembly/binaryen#3100 WebAssembly/binaryen#3102

[MaxGraey]

I think it's last one. Could you open issue?

[dcodeIO]

Perhaps, before opening an issue, we might try to see if we can find the problem by injecting a couple checks for null in Binaryen itself. I guess a PR just fixing this would be ideal :)

[MaxGraey]

I'm not sure this a good idea. It will be much harder try to fix from our side

[github-actions]

🎉 This PR is included in version 0.14.11 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀