Skip to content

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Oct 11, 2020

Move code-folding little bit lower in pipeline.
Remove and simplify some inline passes.

All this changes slightly improve codegen quality and increase optimization speed

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO October 11, 2020 17:24
passes.push("vacuum");

passes.push("inlining-optimizing");
passes.push("inlining");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: What's the different between inlining and inlining-optimizing? Is the latter unnecessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems inlining-optimizing also apply constant propagation but only for specific part or something like this

@MaxGraey
Copy link
Member Author

Great news! Time of bootstrap compilation reduced from > 2 sec to 1.37 sec. I think it's ready

@dcodeIO dcodeIO merged commit b4ca3f9 into AssemblyScript:master Oct 12, 2020
@github-actions
Copy link

🎉 This PR is included in version 0.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants