Skip to content

Fix for issue-1507 illegal Imports.env with a type conflict to the indexer in in… #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcodeIO merged 6 commits into from
Oct 16, 2020
Merged

Fix for issue-1507 illegal Imports.env with a type conflict to the indexer in in… #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b8388c
Fix for illegal Imports.env with a type conflict to the indexer in in…
Oct 16, 2020
b260be7
Changed to Imports[key: string]: Record<string,unknown>|undefined
Oct 16, 2020
d46f7e6
Removed unnecessary comment.
Oct 16, 2020
d20481e
Added myself to the NOTICE file.
Oct 16, 2020
f4d800d
Added myself to the NOTICE file.
Oct 16, 2020
4a1e63d
Changed me to another email address.
Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ under the licensing terms detailed in LICENSE:
* Maël Nison <nison.mael@gmail.com>
* Valeria Viana Gusmao <valeria.viana.gusmao@gmail.com>
* Gabor Greif <ggreif@gmail.com>
* Martin Fredriksson <martin.fredriksson@vikinganalytics.se>

Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
2 changes: 1 addition & 1 deletion lib/loader/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface ResultObject {

/** WebAssembly imports with an optional env object and two levels of nesting. */
export type Imports = {
[key: string]: Record<string,unknown>;
[key: string]: Record<string,unknown> | undefined;
env?: {
memory?: WebAssembly.Memory;
table?: WebAssembly.Table;
Expand Down