Skip to content

add index signature to ArrayLike #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trusktr wants to merge 2 commits into from
Closed

add index signature to ArrayLike #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e7a48a
add index type to ArrayLike
trusktr Nov 15, 2020
d42989b
Update NOTICE
trusktr Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ under the licensing terms detailed in LICENSE:
* Valeria Viana Gusmao <valeria.viana.gusmao@gmail.com>
* Gabor Greif <ggreif@gmail.com>
* Martin Fredriksson <martin.fredriksson@vikinganalytics.se>
* Joe Pea (@trusktr) <trusktr@gmail.com>
* Joe Pea (@trusktr) <joe@trusktr.io>
Comment on lines +32 to +33
Copy link
Member

@dcodeIO dcodeIO Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to pick one and stick with the format because the NOTICE file is also parsed to generate contributors in package.json for example.


Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
2 changes: 1 addition & 1 deletion std/assembly/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,7 @@ declare class DataView {

interface ArrayLike<T> {
length: i32;
// [key: number]: T;
[key: number]: T;
}

/** Interface for a typed view on an array buffer. */
Expand Down