Skip to content

fix: Fix binary util discarding bits when compiling to Wasm #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcodeIO merged 1 commit into from
Dec 18, 2020
Merged

fix: Fix binary util discarding bits when compiling to Wasm #1589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/util/binary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export function writeI8(value: i32, buffer: Uint8Array, offset: i32): void {

/** Reads a 16-bit integer from the specified buffer. */
export function readI16(buffer: Uint8Array, offset: i32): i32 {
return buffer[offset ]
| buffer[offset + 1] << 8;
return i32(buffer[offset ])
| i32(buffer[offset + 1]) << 8;
}

/** Writes a 16-bit integer to the specified buffer. */
Expand All @@ -27,10 +27,10 @@ export function writeI16(value: i32, buffer: Uint8Array, offset: i32): void {

/** Reads a 32-bit integer from the specified buffer. */
export function readI32(buffer: Uint8Array, offset: i32): i32 {
return buffer[offset ]
| buffer[offset + 1] << 8
| buffer[offset + 2] << 16
| buffer[offset + 3] << 24;
return i32(buffer[offset ])
| i32(buffer[offset + 1]) << 8
| i32(buffer[offset + 2]) << 16
| i32(buffer[offset + 3]) << 24;
}

/** Writes a 32-bit integer to the specified buffer. */
Expand Down