Skip to content

Emit a diagnostic when 'super' is called in ctor of a non-derived class #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcodeIO merged 1 commit into from
Feb 8, 2021
Merged

Emit a diagnostic when 'super' is called in ctor of a non-derived class #1678

dcodeIO merged 1 commit into from
Feb 8, 2021

Conversation

@dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Feb 8, 2021

Calling super in the constructor of a non-derived class was hitting an assertion. Emit a diagnostic instead.

fixes #1677

  • I've read the contributing guidelines

@saulecabrera
Copy link
Contributor

saulecabrera commented Feb 8, 2021 •
edited
Loading

Thanks for the quick fix!

@dcodeIO dcodeIO merged commit 7f6c51c into master Feb 8, 2021
@dcodeIO dcodeIO deleted the issue-1677 branch June 1, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use of super in a non-derived class results in an assertion

4 participants

@dcodeIO @saulecabrera @MaxGraey