Skip to content

Conversation

@MaxGraey
Copy link
Member

Patch references 1 and 2

@dcodeIO
Copy link
Member

dcodeIO commented Mar 22, 2021

I am not a fan of the formatting changes, as it makes PRs a little hard to grasp. I am OK with leaving it this way, though, but can you perhaps at a line comment (here on GH in the PR) with a bit of background where the code changes are and what they do?

Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@dcodeIO dcodeIO merged commit 3005c64 into AssemblyScript:master Mar 27, 2021
@MaxGraey MaxGraey deleted the backport-musl-math-fixes branch March 27, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants