fix: Fix and refactor Date #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Apr 14, 2021
This comment has been minimized.
This comment has been minimized.
torch2424
approved these changes
Apr 21, 2021
Contributor
torch2424
left a comment
torch2424
left a comment
There was a problem hiding this comment.
I did a quick review, and this PR looks good to me 😄
Also, shoutout to @ColinEberhardt for kicking this off! 😄 🎉
ColinEberhardt
approved these changes
Apr 23, 2021
Contributor
ColinEberhardt
left a comment
ColinEberhardt
left a comment
There was a problem hiding this comment.
Looks spot on to me - thanks @MaxGraey
Member
Author
|
@ColinEberhardt thanks! I'll merge this when node nightly build (canary) will be available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some post improvements and refactors for feat: implemented getters / setters and various string fns on Date #1768
Add getUTCDay
I've read the contributing guidelines