Skip to content

fix: More proper Math.round #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGraey merged 1 commit into from
May 19, 2021
Merged

fix: More proper Math.round #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions std/assembly/math.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,8 @@ export namespace NativeMath {
// @ts-ignore: decorator
@inline
export function round(x: f64): f64 {
return builtin_copysign<f64>(builtin_floor<f64>(x + 0.5), x);
let roundUp = builtin_ceil<f64>(x);
return select<f64>(roundUp, roundUp - 1.0, roundUp - 0.5 <= x);
}

// @ts-ignore: decorator
Expand Down Expand Up @@ -2732,7 +2733,8 @@ export namespace NativeMathf {
// @ts-ignore: decorator
@inline
export function round(x: f32): f32 {
return builtin_copysign<f32>(builtin_floor<f32>(x + 0.5), x);
let roundUp = builtin_ceil<f32>(x);
return select<f32>(roundUp, roundUp - 1.0, roundUp - 0.5 <= x);
}

// @ts-ignore: decorator
Expand Down
Loading