Skip to content

Conversation

@dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jul 13, 2021

This is a (not very good) attempt to address issues like #1975 and #1948, where two different versions of the portable glue are mistakenly being included. It doesn't really fix the base problem, because one will most likely also include multiple versions of the compiler which will explode another way. But perhaps it depends on exact use case whether it works or not?

  • I've read the contributing guidelines

@dcodeIO dcodeIO requested a review from willemneal July 13, 2021 08:30
@willemneal
Copy link
Contributor

While this will certainly be a solution the error, I still think it will promote transforms with various different versions of the complier. Though perhaps the transform author has a reason for this?

I propose that in addition to this change, the transform interface is updated so that each transform is passed a reference to assemblyscript. This way there is no need for any transform to have the complier as a dependency and will ensure that there is only one version present. However, with your change the transform author can import a particular version of the compiler and not have it blow up.

Wdyt?

@dcodeIO
Copy link
Member Author

dcodeIO commented Sep 4, 2021

Whoops, tried force-pushing a rebase but that somehow closed it. See new PR above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants