fix: check function's instance class is a subclass of virtual method #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
reviewed
Jul 15, 2021
MaxGraey
reviewed
Jul 15, 2021
dcodeIO
reviewed
Jul 15, 2021
MaxGraey
reviewed
Jul 15, 2021
Co-authored-by: Max Graey <maxgraey@gmail.com>
Contributor
Author
dcodeIO
reviewed
Jul 19, 2021
Contributor
Author
|
@MaxGraey Thoughts? |
dcodeIO
approved these changes
Jul 21, 2021
MaxGraey
approved these changes
Jul 21, 2021
Contributor
Author
|
@MaxGraey Are we waiting to release this with a major bump? It should be a patch and could be merged now. |
Contributor
Author
|
@MaxGraey, this is bug is a blocker for me. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1971
Generic base classes have an issue where all instances regardless of generic are collected as instances of its virtual methods. This checks to make sure that only methods from classes that extend the generic base class are added to the virtual table.