Skip to content

fix: proper error for block scoped class expressions #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 2 commits into from
Aug 2, 2021
Merged

fix: proper error for block scoped class expressions #2012

MaxGraey merged 2 commits into from
Aug 2, 2021

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jul 28, 2021 •
edited
Loading

example:

{ class InnerClass {} }

Output:

ERROR AS100: Not implemented: Block-scoped class declarations or expressions

   { class InnerClass {} }
     ~~~~~~~~~~~~~~~~~~~
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO July 28, 2021 20:51
@MaxGraey MaxGraey merged commit 75890dc into AssemblyScript:main Aug 2, 2021
@MaxGraey MaxGraey deleted the fix-class-in-block-decl branch August 2, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO