Skip to content

fix: Expression passed to evaluateCondition asserted to be valid #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 4 commits into from
Aug 2, 2021
Merged

fix: Expression passed to evaluateCondition asserted to be valid #2013

MaxGraey merged 4 commits into from
Aug 2, 2021

Conversation

@romdotdog
Copy link
Contributor

@romdotdog romdotdog commented Jul 30, 2021

getExpressionType can return Unreachable type if expression passed is invalid
fixes #1990

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

dcodeIO
dcodeIO reviewed Jul 31, 2021
View reviewed changes
@MaxGraey MaxGraey changed the title Expression passed to evaluateCondition asserted to be valid fix: Expression passed to evaluateCondition asserted to be valid Jul 31, 2021
@MaxGraey MaxGraey merged commit 81c2bad into AssemblyScript:main Aug 2, 2021
@MaxGraey
Copy link
Member

MaxGraey commented Aug 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler crash for instance properties without this

3 participants

@romdotdog @MaxGraey @dcodeIO