Skip to content

Add shortcuts for some non-tagged string templates #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 16 commits into from
Aug 2, 2021
Merged

Add shortcuts for some non-tagged string templates #2014

MaxGraey merged 16 commits into from
Aug 2, 2021

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 1, 2021 •
edited
Loading

Simplify following special cases:

`${expr}`           ->  expr.toString()
`pref${expr}`       ->  "pref" + expr.toString()
`${expr}suff`       ->  expr.toString() + "suff"
`${exprA}${exprB}`  ->  exprA.toString() + exprB.toString()
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey changed the title Add shortcut for ${expr} string templates Add shortcuts for ${expr}, pref${expr} and ${expr}suff string templates Aug 1, 2021
@MaxGraey MaxGraey changed the title Add shortcuts for ${expr}, pref${expr} and ${expr}suff string templates Add shortcuts for some string templates Aug 1, 2021
@MaxGraey MaxGraey changed the title Add shortcuts for some string templates Add shortcuts for some non-tagged string templates Aug 1, 2021
@MaxGraey MaxGraey requested a review from dcodeIO August 1, 2021 15:06
@MaxGraey MaxGraey merged commit 551b312 into AssemblyScript:main Aug 2, 2021
@MaxGraey MaxGraey deleted the opt-template-strings branch August 2, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

enhancement performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO