Skip to content

Add useDefineForClassFields = false and some extra check flags #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 1 commit into from
Nov 15, 2021
Merged

Add useDefineForClassFields = false and some extra check flags #2145

MaxGraey merged 1 commit into from
Nov 15, 2021

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Nov 15, 2021

This set useDefineForClassFields to false. See:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier

Which significantly speedup TS and it's emits.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO November 15, 2021 19:02
@MaxGraey MaxGraey merged commit 52255f5 into AssemblyScript:main Nov 15, 2021
@MaxGraey MaxGraey deleted the opt-ts-emit branch November 15, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

enhancement performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO