Add rem builtin for i32 and i64 (#1310)

[adrien-zinger]

Implement the builtin rem for i32 and i64, requested in the issue #1310

• I've read the contributing guidelines
• I've added my name and email to the NOTICE file

[MaxGraey]

Hi! Thanks for PR. Similar to division builtins it should be splitted to rem_s and rem_u. See:

assemblyscript/src/builtins.ts

Line 6826 in a2acee0

function builtin_i32_div_s(ctx: BuiltinContext): ExpressionRef {

assemblyscript/src/builtins.ts

Line 6835 in a2acee0

function builtin_i32_div_u(ctx: BuiltinContext): ExpressionRef {

[adrien-zinger]

Thanks for the review @MaxGraey! I just implemented the split. I have a doubt on types in the std because the div_s and div_u have both a i32/64 type for the parameters. It should be u32/64 right? Even if the compiler will reinterpret those types later (if I understand correctly 😄 ).

[dcodeIO]

Thanks, looks good, just a few nits on wording above :)

Regarding

I have a doubt on types in the std because the div_s and div_u have both a i32/64 type for the parameters. It should be u32/64 right? Even if the compiler will reinterpret those types later (if I understand correctly 😄 ).

In the .d.ts, the numeric types are merely aliases of number, so I guess that's why the discrepancy hasn't been noticed before. Doesn't harm to unify these, as you suggest. Perhaps as another PR?

[adrien-zinger]

In the .d.ts, the numeric types are merely aliases of number, so I guess that's why the discrepancy hasn't been noticed before. Doesn't harm to unify these, as you suggest. Perhaps as another PR?

Thanks for your review! I can change that in another PR as you said 👍