Skip to content

Add fast paths for array's fill method #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxGraey merged 2 commits into from
Jun 7, 2022
Merged

Add fast paths for array's fill method #2307

MaxGraey merged 2 commits into from
Jun 7, 2022

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jun 3, 2022

When value equal to +0 or -1 we can use fast memory.fill regardless of the type size of argument.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO June 3, 2022 19:57
@MaxGraey MaxGraey merged commit 3ff1003 into AssemblyScript:main Jun 7, 2022
@MaxGraey MaxGraey deleted the opt-fill-zeros branch June 7, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees

No one assigned

Labels

performance standard library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO